From: endico%mozilla.org <>
Date: Fri, 6 Aug 1999 03:48:51 +0000 (+0000)
Subject: don't offer most doomed report if this bugzilla installation doesn't use milestones... 
X-Git-Tag: bugzilla-2.6~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a50e5a0bb04f44efda1fd3c0b5810708521c3323;p=thirdparty%2Fbugzilla.git

don't offer most doomed report if this bugzilla installation doesn't use milestones. remove semicolons from sql queries. the version of mysql running on lounge throws an error on semicoloned queries.
---

diff --git a/reports.cgi b/reports.cgi
index a8de9f8044..992f60fa34 100755
--- a/reports.cgi
+++ b/reports.cgi
@@ -133,7 +133,11 @@ $product_popup
 <td align=center>
 <select name="output">
 <option value="most_doomed">Bug Counts
-<option value="most_doomed_for_milestone">Most Doomed
+FIN
+        if (Param('usetargetmilestone')) {
+            print "<option value=\"most_doomed_for_milestone\">Most Doomed";
+            }
+	print <<FIN;
 $charts
 </select>
 <tr>
@@ -572,7 +576,7 @@ FIN
         my $bugtotal = 0;
         foreach $person (@people)
                 {
-                SendSQL ("select count(bug_id) from bugs,profiles where target_milestone=\"$ms\" and userid=assigned_to and userid=\"$person\";");
+                SendSQL ("select count(bug_id) from bugs,profiles where target_milestone=\"$ms\" and userid=assigned_to and userid=\"$person\"");
 	        my $bugcount = FetchSQLData();
                 $bugsperperson{$person} = $bugcount;
                 $bugtotal += $bugcount;
@@ -594,7 +598,7 @@ FIN
                 {
                 $person = pop @people;
                 print "<TR><TD>\n";
-                SendSQL("select login_name from profiles where userid=$person;");
+                SendSQL("select login_name from profiles where userid=$person");
                 my $login_name= FetchSQLData();
                 print("<A HREF=\"buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&target_milestone=M9&assigned_to=$login_name\">\n");
                 print("$bugsperperson{$person}  bugs and features");
@@ -607,7 +611,7 @@ FIN
 
                 $person = pop @people;
                 if ($person) {
-                    SendSQL("select login_name from profiles where userid=$person;");
+                    SendSQL("select login_name from profiles where userid=$person");
                     my $login_name= FetchSQLData();
                     print("<A HREF=\"buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&target_milestone=M9&assigned_to=$login_name\">\n");
                     print("$bugsperperson{$person}  bugs and features");