From: Lukasz Dorau Date: Mon, 14 Nov 2011 14:52:52 +0000 (+0100) Subject: imsm: fix: correct checking newly missing disks X-Git-Tag: mdadm-3.2.3~58 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a510b1c7f07ba750979ba2f213ebe261bcfc4de4;p=thirdparty%2Fmdadm.git imsm: fix: correct checking newly missing disks The problem occurs when RAID10 array under rebuild (after one disk fails) is assembled incrementally. Mdadm tries to start array just after adding the third disk and the volume is assembled incorrectly (in degraded state). The cause is that container_enough depends on newly missing disks which are checked incorrectly now. They should be checked using always the first map. Signed-off-by: Lukasz Dorau Signed-off-by: NeilBrown --- diff --git a/super-intel.c b/super-intel.c index d80c5df9..37ade912 100644 --- a/super-intel.c +++ b/super-intel.c @@ -2529,13 +2529,13 @@ static void getinfo_super_imsm(struct supertype *st, struct mdinfo *info, char * failed = imsm_count_failed(super, dev); state = imsm_check_degraded(super, dev, failed); - map = get_imsm_map(dev, dev->vol.migr_state); + map = get_imsm_map(dev, 0); /* any newly missing disks? * (catches single-degraded vs double-degraded) */ for (j = 0; j < map->num_members; j++) { - __u32 ord = get_imsm_ord_tbl_ent(dev, i, -1); + __u32 ord = get_imsm_ord_tbl_ent(dev, i, 0); __u32 idx = ord_to_idx(ord); if (!(ord & IMSM_ORD_REBUILD) &&