From: mkanat%bugzilla.org <>
Date: Tue, 1 Aug 2006 05:22:51 +0000 (+0000)
Subject: Bug 346554: Remove checksetup's checks for modules that are included with perl 5.8.0
X-Git-Tag: bugzilla-2.23.3~203
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a5172adf10d1e820f5099e78e6b967f0b019936b;p=thirdparty%2Fbugzilla.git

Bug 346554: Remove checksetup's checks for modules that are included with perl 5.8.0
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) r=colin for docs, a=myk
---

diff --git a/Bugzilla/Install/Requirements.pm b/Bugzilla/Install/Requirements.pm
index 97ea5c6270..c5342966aa 100644
--- a/Bugzilla/Install/Requirements.pm
+++ b/Bugzilla/Install/Requirements.pm
@@ -42,10 +42,6 @@ use constant REQUIRED_MODULES => [
         name => 'CGI',
         version => '2.93'
     },
-    {
-        name => 'Data::Dumper',
-        version => '0'
-    },
     {
         name => 'Date::Format',
         version => '2.21'
@@ -58,18 +54,10 @@ use constant REQUIRED_MODULES => [
         name => 'File::Spec',
         version => '0.84'
     },
-    {
-        name => 'File::Temp',
-        version => '0'
-    },
     {
         name => 'Template',
         version => '2.08'
     },
-    {
-        name => 'Text::Wrap',
-        version => '2001.0131'
-    },
     {
         name => 'Mail::Mailer',
         version => '1.67'
@@ -83,10 +71,6 @@ use constant REQUIRED_MODULES => [
         name => $^O =~ /MSWin32/i ? 'MIME::Tools' : 'MIME::Parser',
         version => '5.406'
     },
-    {
-        name => 'Storable',
-        version => '0'
-    },
 ];
 
 use constant OPTIONAL_MODULES => [
diff --git a/docs/xml/faq.xml b/docs/xml/faq.xml
index d2cb5f5e08..9473710190 100644
--- a/docs/xml/faq.xml
+++ b/docs/xml/faq.xml
@@ -1276,7 +1276,7 @@ password=mypassword
                 </para>
               </listitem>
             </orderedlist>
-            I reckon TimeDate and Data::Dumper come with the activeperl.
+            I reckon TimeDate comes with the activeperl.
             You can check the ActiveState site for packages for installation
             through PPM. <ulink url="http://www.activestate.com/Packages/"/>.
           </para>
diff --git a/docs/xml/installation.xml b/docs/xml/installation.xml
index 9e9080609c..7b3ded001c 100644
--- a/docs/xml/installation.xml
+++ b/docs/xml/installation.xml
@@ -1,5 +1,5 @@
 <!-- <!DOCTYPE chapter PUBLIC "-//OASIS//DTD DocBook XML V4.1.2//EN"> -->
-<!-- $Id: installation.xml,v 1.125 2006/07/31 22:21:35 mkanat%bugzilla.org Exp $ -->
+<!-- $Id: installation.xml,v 1.126 2006/07/31 22:22:51 mkanat%bugzilla.org Exp $ -->
 <chapter id="installing-bugzilla">
   <title>Installing Bugzilla</title>
 
@@ -291,12 +291,6 @@
           </para>
         </listitem>
 
-        <listitem>
-          <para>
-            Data::Dumper (&min-data-dumper-ver;)
-          </para>
-        </listitem>
-    
         <listitem>
           <para>
             Date::Format (&min-date-format-ver;)
@@ -328,12 +322,6 @@
           </para>
         </listitem>
 
-        <listitem>
-          <para>
-            File::Temp (&min-file-temp-ver;)
-          </para>
-        </listitem>
-
         <listitem>
           <para>
             <link linkend="install-modules-template">Template</link>
@@ -341,12 +329,6 @@
           </para>
         </listitem>
 
-        <listitem>
-          <para>
-            Text::Wrap (&min-text-wrap-ver;)
-          </para>
-        </listitem>
-
         <listitem>
           <para>
             Mail::Mailer (&min-mail-mailer-ver;)
@@ -364,12 +346,6 @@
             MIME::Parser (&min-mime-parser-ver;)
           </para>
         </listitem>
-
-        <listitem>
-          <para>
-            Storable (&min-storable-ver;)
-          </para>
-        </listitem>
       </orderedlist>
 
       Optional Perl modules:
diff --git a/docs/xml/modules.xml b/docs/xml/modules.xml
index e2912d6a8c..2e20bdc564 100644
--- a/docs/xml/modules.xml
+++ b/docs/xml/modules.xml
@@ -103,15 +103,6 @@
       </literallayout>
     </para>
 
-    <para>
-      File::Temp:
-      <literallayout>
-        CPAN Download Page: <ulink url="http://search.cpan.org/dist/File-Temp/"/>
-        PPM Download Page: Part of core distribution.
-        Documentation: <ulink url="http://www.perldoc.com/perl5.8.0/lib/File/Temp.html"/>
-      </literallayout>
-    </para>
-
     <para>
       Template-Toolkit:
       <literallayout>
@@ -121,15 +112,6 @@
       </literallayout>
     </para>
 
-    <para>
-       Text::Wrap:
-      <literallayout>
-        CPAN Download Page: <ulink url="http://search.cpan.org/dist/Text-Tabs+Wrap/"/>
-        PPM Download Link: Part of core distribution.
-        Documentation: <ulink url="http://www.perldoc.com/perl5.8.0/lib/Text/Wrap.html"/>
-      </literallayout>
-    </para>
- 
     <para>
       GD:
       <literallayout>
diff --git a/docs/xml/requiredsoftware.xml b/docs/xml/requiredsoftware.xml
index 8a8c35774c..4a751c0c74 100644
--- a/docs/xml/requiredsoftware.xml
+++ b/docs/xml/requiredsoftware.xml
@@ -31,10 +31,6 @@
   <ulink url="http://www.cpan.org/modules/by-module/DBI/"/>
   </para>
 
-  <para>Data::Dumper module: 
-  <ulink url="http://www.cpan.org/modules/by-module/Data/"/>
-  </para>
-
   <para>MySQL related Perl modules: 
   <ulink url="http://www.cpan.org/modules/by-module/Mysql/"/>
   </para>
diff --git a/docs/xml/troubleshooting.xml b/docs/xml/troubleshooting.xml
index acf59f7a3a..019ca010a1 100644
--- a/docs/xml/troubleshooting.xml
+++ b/docs/xml/troubleshooting.xml
@@ -1,5 +1,5 @@
 <!-- <!DOCTYPE chapter PUBLIC "-//OASIS//DTD DocBook XML V4.1.2//EN"> -->
-<!-- $Id: troubleshooting.xml,v 1.11 2006/06/07 20:11:03 uid623 Exp $ -->
+<!-- $Id: troubleshooting.xml,v 1.12 2006/07/31 22:22:51 mkanat%bugzilla.org Exp $ -->
 
 <appendix id="troubleshooting">
 <title>Troubleshooting</title>
@@ -139,49 +139,6 @@ TEST-OK Webserver is preventing fetch of http://landfill.bugzilla.org/bugzilla-t
     </para>
   </section>    
 
-  <section id="trouble-filetemp">
-  <title>Your vendor has not defined Fcntl macro O_NOINHERIT</title>
-
-    <para>This is caused by a bug in the version of
-    <productname>File::Temp</productname> that is distributed with perl
-    5.6.0. Many minor variations of this error have been reported:
-    </para>
-
-    <programlisting>Your vendor has not defined Fcntl macro O_NOINHERIT, used 
-at /usr/lib/perl5/site_perl/5.6.0/File/Temp.pm line 208.
-
-Your vendor has not defined Fcntl macro O_EXLOCK, used 
-at /usr/lib/perl5/site_perl/5.6.0/File/Temp.pm line 210.
-
-Your vendor has not defined Fcntl macro O_TEMPORARY, used 
-at /usr/lib/perl5/site_perl/5.6.0/File/Temp.pm line 233.</programlisting>
-
-    <para>Numerous people have reported that upgrading to version 5.6.1
-    or higher solved the problem for them. A less involved fix is to apply
-    the following patch, which is also
-    available as a <ulink url="../xml/filetemp.patch">patch file</ulink>.
-    </para>
-
-    <programlisting><![CDATA[--- File/Temp.pm.orig   Thu Feb  6 16:26:00 2003
-+++ File/Temp.pm        Thu Feb  6 16:26:23 2003
-@@ -205,6 +205,7 @@
-     # eg CGI::Carp
-     local $SIG{__DIE__} = sub {};
-     local $SIG{__WARN__} = sub {};
-+    local *CORE::GLOBAL::die = sub {};
-     $bit = &$func();
-     1;
-   };
-@@ -226,6 +227,7 @@
-     # eg CGI::Carp
-     local $SIG{__DIE__} = sub {};
-     local $SIG{__WARN__} = sub {};
-+    local *CORE::GLOBAL::die = sub {};
-     $bit = &$func();
-     1;
-   };]]></programlisting>
-  </section>
-
   <section id="trbl-relogin-everyone">
   <title>Everybody is constantly being forced to relogin</title>