From: Ben Darnell <ben@cockroachlabs.com>
Date: Sat, 20 Jun 2020 17:09:59 +0000 (-0400)
Subject: auth: Fix example code
X-Git-Tag: v6.1.0b1~19^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a52f76c900a0372264508390c52ab29f3c000254;p=thirdparty%2Ftornado.git

auth: Fix example code

Continuation of #2811

The oauth2 version of authorize_redirect is no longer a coroutine, so
don't use await in example code. The oauth1 version is still a
coroutine, but one twitter example was incorrectly calling it with
yield instead of await.
---

diff --git a/tornado/auth.py b/tornado/auth.py
index 69927cc32..5f1068c95 100644
--- a/tornado/auth.py
+++ b/tornado/auth.py
@@ -634,7 +634,7 @@ class OAuth2Mixin(object):
 
                     if not new_entry:
                         # Call failed; perhaps missing permission?
-                        await self.authorize_redirect()
+                        self.authorize_redirect()
                         return
                     self.finish("Posted a message!")
 
@@ -772,7 +772,7 @@ class TwitterMixin(OAuthMixin):
                         access_token=self.current_user["access_token"])
                     if not new_entry:
                         # Call failed; perhaps missing permission?
-                        yield self.authorize_redirect()
+                        await self.authorize_redirect()
                         return
                     self.finish("Posted a message!")
 
@@ -954,7 +954,7 @@ class FacebookGraphMixin(OAuth2Mixin):
                           code=self.get_argument("code"))
                       # Save the user with e.g. set_secure_cookie
                   else:
-                      await self.authorize_redirect(
+                      self.authorize_redirect(
                           redirect_uri='/auth/facebookgraph/',
                           client_id=self.settings["facebook_api_key"],
                           extra_params={"scope": "read_stream,offline_access"})
@@ -1072,7 +1072,7 @@ class FacebookGraphMixin(OAuth2Mixin):
 
                     if not new_entry:
                         # Call failed; perhaps missing permission?
-                        yield self.authorize_redirect()
+                        self.authorize_redirect()
                         return
                     self.finish("Posted a message!")