From: Arvin Schnell <aschnell@suse.de>
Date: Mon, 28 Feb 2011 16:43:29 +0000 (+0100)
Subject: - comply to various packaging rules
X-Git-Tag: v0.1.3~448
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a52fb13d10dce84b2ee726733f4b9b531a699b7f;p=thirdparty%2Fsnapper.git

- comply to various packaging rules
---

diff --git a/configure.in b/configure.in
index 4f345548..66a43bd8 100644
--- a/configure.in
+++ b/configure.in
@@ -23,12 +23,10 @@ CXXFLAGS="${CXXFLAGS} -std=c++0x -DHAVE_CXX0X -Wall -Wextra -Wformat=2 -Wnon-vir
 
 docdir=\${prefix}/share/doc/packages/snapper
 fillupdir=/var/adm/fillup-templates
-logrotatedir=/etc/logrotate.d
 
 AC_SUBST(VERSION)
 AC_SUBST(docdir)
 AC_SUBST(fillupdir)
-AC_SUBST(logrotatedir)
 
 AC_OUTPUT(
 	Makefile
diff --git a/data/Makefile.am b/data/Makefile.am
index ce7000e8..afe71b6e 100644
--- a/data/Makefile.am
+++ b/data/Makefile.am
@@ -4,10 +4,9 @@
 
 fillup_DATA = sysconfig.snapper
 
-logrotate_DATA = snapper
-
-EXTRA_DIST = $(fillup_DATA) $(logrotate_DATA)
+EXTRA_DIST = $(fillup_DATA) snapper.logrotate
 
 install-data-local:
-	mkdir -p $(DESTDIR)/etc/sysconfig/snapper.d
+	install -D -m 644 snapper.logrotate $(DESTDIR)/etc/logrotate.d/snapper
+	install -d -m 755 $(DESTDIR)/etc/snapper/configs
 
diff --git a/data/snapper b/data/snapper.logrotate
similarity index 100%
rename from data/snapper
rename to data/snapper.logrotate
diff --git a/scripts/Makefile.am b/scripts/Makefile.am
index ac1479c8..38d9c9a0 100644
--- a/scripts/Makefile.am
+++ b/scripts/Makefile.am
@@ -2,15 +2,9 @@
 # Makefile.am for snapper/scripts
 #
 
-hourlydir = /etc/cron.hourly
+EXTRA_DIST = snapper-hourly snapper-daily
 
-hourly_SCRIPTS = snapper-hourly
-
-
-dailydir = /etc/cron.daily
-
-daily_SCRIPTS = snapper-daily
-
-
-EXTRA_DIST = $(hourly_SCRIPTS) $(daily_SCRIPTS)
+install-data-local:
+	install -D snapper-hourly $(DESTDIR)/etc/cron.hourly/suse.de-snapper
+	install -D snapper-daily $(DESTDIR)/etc/cron.daily/suse.de-snapper
 
diff --git a/scripts/snapper-daily b/scripts/snapper-daily
index 64f4a9e2..b6d1976a 100755
--- a/scripts/snapper-daily
+++ b/scripts/snapper-daily
@@ -24,7 +24,7 @@ for CONFIG in $SNAPPER_CONFIGS ; do
     NUMBER_CLEANUP="no"
     TIMELINE_CLEANUP="no"
 
-    . /etc/sysconfig/snapper.d/$CONFIG
+    . /etc/snapper/configs/$CONFIG
 
     if [ "$NUMBER_CLEANUP" = "yes" ] ; then
 	snapper --config=$CONFIG cleanup number
diff --git a/scripts/snapper-hourly b/scripts/snapper-hourly
index da1bb737..46cd781d 100755
--- a/scripts/snapper-hourly
+++ b/scripts/snapper-hourly
@@ -23,7 +23,7 @@ for CONFIG in $SNAPPER_CONFIGS ; do
 
     TIMELINE_CREATE="no"
 
-    . /etc/sysconfig/snapper.d/$CONFIG
+    . /etc/snapper/configs/$CONFIG
 
     if [ "$TIMELINE_CREATE" = "yes" ] ; then
 	snapper --config=$CONFIG create --description="timeline" --cleanup="timeline"
diff --git a/snapper.spec.in b/snapper.spec.in
index eb9bc845..8da089e2 100644
--- a/snapper.spec.in
+++ b/snapper.spec.in
@@ -14,7 +14,7 @@ Source1:	snapper-rpmlintrc
 Prefix:		/usr
 BuildRequires:	gcc-c++ boost-devel blocxx-devel doxygen dejagnu libxml2-devel
 Requires:	libsnapper = %version
-Recommends:	cron
+Recommends:	cron logrotate
 Summary:	Tool for filesystem snapshot management
 
 %description
@@ -50,14 +50,14 @@ rm -rf "$RPM_BUILD_ROOT"
 %files
 %defattr(-,root,root)
 %{prefix}/bin/snapper
-/etc/cron.hourly/snapper-hourly
-/etc/cron.daily/snapper-daily
+%config(noreplace) %{_sysconfdir}/logrotate.d/snapper
+/etc/cron.hourly/suse.de-snapper
+/etc/cron.daily/suse.de-snapper
 
 %package -n libsnapper
 Summary:	Library for filesystem snapshot management
 Group:		System/Libraries
 Requires:	btrfsprogs diffutils
-Recommends:	logrotate
 PreReq:		%fillup_prereq
 
 %description -n libsnapper
@@ -70,8 +70,8 @@ Authors:
 %files -n libsnapper
 %defattr(-,root,root)
 %{_libdir}/libsnapper.so.*
-%dir %{_sysconfdir}/sysconfig/snapper.d
-%config(noreplace) %{_sysconfdir}/logrotate.d/snapper
+%dir %{_sysconfdir}/snapper
+%dir %{_sysconfdir}/snapper/configs
 %doc %dir %{prefix}/share/doc/packages/snapper
 %doc %{prefix}/share/doc/packages/snapper/AUTHORS
 %doc %{prefix}/share/doc/packages/snapper/COPYING
diff --git a/snapper/Snapper.cc b/snapper/Snapper.cc
index a0becc55..570c07e5 100644
--- a/snapper/Snapper.cc
+++ b/snapper/Snapper.cc
@@ -50,7 +50,7 @@ namespace snapper
 	y2mil("libsnapper version " VERSION);
 	y2mil("config_name:" << config_name);
 
-	config = new SysconfigFile((CONFIGDIR "/" + config_name).c_str());
+	config = new SysconfigFile((CONFIGSDIR "/" + config_name).c_str());
 
 	string val;
 	if (config->getValue("SUBVOLUME", val))
diff --git a/snapper/SnapperDefines.h b/snapper/SnapperDefines.h
index 611034b5..ca384762 100644
--- a/snapper/SnapperDefines.h
+++ b/snapper/SnapperDefines.h
@@ -24,7 +24,7 @@
 #define SNAPPER_DEFINES_H
 
 
-#define CONFIGDIR "/etc/sysconfig/snapper.d"
+#define CONFIGSDIR "/etc/snapper/configs"
 
 #define SNAPSHOTDIR "/snapshot"
 #define SNAPSHOTSDIR "/snapshots"