From: Wang King <king.wang@huawei.com>
Date: Tue, 10 Jan 2017 06:23:49 +0000 (+0800)
Subject: util: unlock closeCallbacks if get callbacks for connect fail
X-Git-Tag: CVE-2017-2635~255
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a563451e2b09f094846bd553286c914916debae6;p=thirdparty%2Flibvirt.git

util: unlock closeCallbacks if get callbacks for connect fail

Avoid return with the closeCallbacks locked when get callbacks list for connect fail.

Signed-off-by: Wang King <king.wang@huawei.com>
Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/util/virclosecallbacks.c b/src/util/virclosecallbacks.c
index 891a92b10d..1fa9596b0e 100644
--- a/src/util/virclosecallbacks.c
+++ b/src/util/virclosecallbacks.c
@@ -331,8 +331,10 @@ virCloseCallbacksRun(virCloseCallbacksPtr closeCallbacks,
 
     virObjectLock(closeCallbacks);
     list = virCloseCallbacksGetForConn(closeCallbacks, conn);
-    if (!list)
+    if (!list) {
+        virObjectLock(closeCallbacks);
         return;
+    }
 
     for (i = 0; i < list->nentries; i++) {
         char uuidstr[VIR_UUID_STRING_BUFLEN];