From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 5 May 2021 09:18:58 +0000 (+0200)
Subject: virDomainVideoDriverDefParseXML: Allow zero value for @vgaconf
X-Git-Tag: v7.4.0-rc1~226
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a573f21f325ae02ea99945e0d16e03ebda58cb00;p=thirdparty%2Flibvirt.git

virDomainVideoDriverDefParseXML: Allow zero value for @vgaconf

It was always allowed, but in a very unusual and weird way. Just
look at the original commit that introduced it (78fc843c7b5).
Also, we document that "io" value is accepted (which translates
to VIR_DOMAIN_VIDEO_VGACONF_IO with value of zero).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3319cb49cf..77105e6a07 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -14326,7 +14326,7 @@ virDomainVideoDriverDefParseXML(xmlNodePtr node,
 
     if (virXMLPropEnum(driver, "vgaconf",
                        virDomainVideoVGAConfTypeFromString,
-                       VIR_XML_PROP_NONZERO, &def->vgaconf) < 0)
+                       VIR_XML_PROP_NONE, &def->vgaconf) < 0)
         return NULL;
 
     return g_steal_pointer(&def);