From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Sat, 19 Apr 2025 22:11:29 +0000 (-0700)
Subject: Fix: do not try deleting original that was moved to trash dir (#9684)
X-Git-Tag: v2.15.3~1^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a57a3dbb300f54e40315790f7725b5a22ab5a12f;p=thirdparty%2Fpaperless-ngx.git

Fix: do not try deleting original that was moved to trash dir (#9684)
---

diff --git a/src/documents/signals/handlers.py b/src/documents/signals/handlers.py
index 16b3a01ea..673ecba52 100644
--- a/src/documents/signals/handlers.py
+++ b/src/documents/signals/handlers.py
@@ -349,11 +349,15 @@ def cleanup_document_deletion(sender, instance, **kwargs):
                 )
                 return
 
-        for filename in (
-            instance.source_path,
+        files = (
             instance.archive_path,
             instance.thumbnail_path,
-        ):
+        )
+        if not settings.EMPTY_TRASH_DIR:
+            # Only delete the original file if we are not moving it to trash dir
+            files += (instance.source_path,)
+
+        for filename in files:
             if filename and os.path.isfile(filename):
                 try:
                     os.unlink(filename)