From: Ray Strode Date: Fri, 1 Apr 2022 16:09:45 +0000 (-0400) Subject: .gitlab-ci: Check for shell errors in CI X-Git-Tag: 23.51.283~91^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a586e59834d68a9e9dd70f6bea460ae086bc5c08;p=thirdparty%2Fplymouth.git .gitlab-ci: Check for shell errors in CI Recently a shell error snuck into CI and I didn't notice it because it was in the tail end of a short-circuited conditional. This commit adds a little shell validation to CI to avoid that sort of thing in the future. --- diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 60faca10..dbae8b96 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,5 +1,6 @@ stages: - build + - shellcheck .autotools-build: &autotools-build script: @@ -8,12 +9,13 @@ stages: - ../configure --prefix /usr - make - make distcheck + - shellcheck -S error scripts/plymouth-* fedora-x86_64: stage: build image: 'registry.fedoraproject.org/fedora:30' before_script: - - dnf install -y gcc libtool intltool gtk3-devel git libpng-devel gettext-devel libxslt docbook-style-xsl cairo-devel systemd-devel systemd-udev kernel-headers libdrm-devel pango-devel make + - dnf install -y gcc libtool intltool gtk3-devel git libpng-devel gettext-devel libxslt docbook-style-xsl cairo-devel systemd-devel systemd-udev kernel-headers libdrm-devel pango-devel make ShellCheck <<: *autotools-build debian-stable-x86_64: @@ -21,5 +23,5 @@ debian-stable-x86_64: image: debian:stable before_script: - apt-get update -qq - - apt-get install -y -qq --no-install-recommends autoconf automake autopoint bc build-essential docbook-xsl gcc gettext git intltool libdrm-dev libgtk-3-dev libpango1.0-dev libpng-dev libtool libudev-dev make pkg-config libsystemd-dev udev xsltproc + - apt-get install -y -qq --no-install-recommends autoconf automake autopoint bc build-essential docbook-xsl gcc gettext git intltool libdrm-dev libgtk-3-dev libpango1.0-dev libpng-dev libtool libudev-dev make pkg-config libsystemd-dev udev xsltproc shellcheck <<: *autotools-build