From: aborah-sudo <aborah@redhat.com>
Date: Wed, 25 Mar 2026 04:19:33 +0000 (+0530)
Subject: Tests: Add a new user with a specified existing numerical primary group
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a58a0dcc1d3420d3aef3fbb159c217c0755a9ecd;p=thirdparty%2Fshadow.git

Tests: Add a new user with a specified existing numerical primary group

This is the transformation to Python of the test located in
`tests/usertools/01/07_useradd_numerical_primary_group.test`, which checks that `useradd` can add a new user with valid existing group as primary
---

diff --git a/tests/system/tests/test_useradd.py b/tests/system/tests/test_useradd.py
index a23cfdd43..5654fdba5 100644
--- a/tests/system/tests/test_useradd.py
+++ b/tests/system/tests/test_useradd.py
@@ -370,7 +370,14 @@ def test_useradd__invalid_primary_group(shadow: Shadow, group_identifier: int |
 
 
 @pytest.mark.topology(KnownTopology.Shadow)
-def test_useradd__valid_group_as_primary(shadow: Shadow):
+@pytest.mark.parametrize(
+    "group_name, group_gid",
+    [
+        pytest.param("testgroup", None, id="valid_named_group"),
+        pytest.param("testgroup5000", 5000, id="valid_numeric_gid"),
+    ],
+)
+def test_useradd__valid_group_as_primary(shadow: Shadow, group_name: str, group_gid: int | None):
     """
     :title: Add a new user with a valid existing group as primary
     :steps:
@@ -385,13 +392,22 @@ def test_useradd__valid_group_as_primary(shadow: Shadow):
         4. User's GID matches the group's GID
     :customerscenario: False
     """
-    shadow.groupadd("testgroup")
+    if group_gid:
+        shadow.groupadd(f"{group_name} -g {group_gid}")
+    else:
+        shadow.groupadd(group_name)
+
+    group_entry = shadow.tools.getent.group(group_name)
+    assert group_entry is not None, f"Group {group_name} should exist"
+    assert group_entry.name == group_name, f"Incorrect group name, expected '{group_name}', got '{group_entry.name}'"
 
-    group_entry = shadow.tools.getent.group("testgroup")
-    assert group_entry is not None, "Group testgroup should exist"
-    assert group_entry.name == "testgroup", f"Incorrect group name, expected 'testgroup', got '{group_entry.name}'"
+    if group_gid:
+        assert group_entry.gid == group_gid, f"Incorrect GID, expected {group_gid}, got {group_entry.gid}"
 
-    shadow.useradd("testuser -g testgroup")
+    if group_gid:
+        shadow.useradd(f"testuser -g {group_gid}")
+    else:
+        shadow.useradd(f"testuser -g {group_name}")
 
     passwd_entry = shadow.tools.getent.passwd("testuser")
     assert passwd_entry is not None, "User testuser should exist"