From: bryce-mozilla%nextbus.com <> Date: Tue, 15 Jun 1999 11:25:28 +0000 (+0000) Subject: Fix several browsers, Lynx and Opera at least. HTML syntax errors here X-Git-Tag: bugzilla-2.6~36 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a59f318781f4f189484ba21206119c36ef3becf8;p=thirdparty%2Fbugzilla.git Fix several browsers, Lynx and Opera at least. HTML syntax errors here and there were fixed, and serverpush was restricted only to the versions of Mozilla known to support it. --- diff --git a/bug_form.pl b/bug_form.pl index a2fb1056bf..9a59ed94d4 100644 --- a/bug_form.pl +++ b/bug_form.pl @@ -207,8 +207,6 @@ if (defined $URL && $URL ne "none" && $URL ne "NULL" && $URL ne "") { } print " -Bug $id -- " . html_quote($bug{'short_desc'}) . - "
@@ -323,7 +321,7 @@ while (MoreSQLData()) { print qq{$date$desc}; $knownattachments{$attachid} = 1; } -print "Create a new attachment (proposed patch, testcase, etc.)\n"; +print "Create a new attachment (proposed patch, testcase, etc.)\n"; sub EmitDependList { @@ -458,7 +456,7 @@ print " Format For Printing
- +
Description: 
Description:  Opened: $bug{'creation_ts'}

@@ -472,9 +470,6 @@ print "
 # long_list.cgi line:
 #  Edit Long Description
 
-
 navigation_header();
 
-print "\n";
-
 1;
diff --git a/buglist.cgi b/buglist.cgi
index 19fc96940d..2aae1de05c 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -25,11 +25,13 @@ use strict;
 require "CGI.pl";
 use Date::Parse;
 
-my $serverpush = 1;
+my $serverpush = 0;
 
-if ($ENV{'HTTP_USER_AGENT'} =~ /MSIE/) {
-    # Internet explorer doesn't seem to understand server push.  What fun.
-    $serverpush = 0;
+if ($ENV{'HTTP_USER_AGENT'} =~ /Mozilla.[3-9]/ && $ENV{'HTTP_USER_AGENT'} !~ /[Cc]ompatible/ ) {
+   # Search for real Netscape 3 and up.  http://www.browsercaps.org used as source of
+   # browsers compatbile with server-push.  It's a Netscape hack, incompatbile
+   # with MSIE and Lynx (at least).
+   $serverpush = 1;
 }
 
 if ($serverpush) {
@@ -121,11 +123,10 @@ Content-type: text/html
 
 
 OK, default is set.
-OK, you now have a new default query.
+OK, you now have a new default query.  You may also bookmark the result of any
+individual query.
 
-

- -Go back to the query page, using the new default. +

Go back to the query page, using the new default. "; exit; }; @@ -821,7 +822,7 @@ if ($count > 0) {    Change columns "; if (!$dotweak && $count > 1) { - print "Make changes to several of these bugs at once.\n"; + print "Change several bugs at once\n"; } } if ($serverpush) { diff --git a/query.cgi b/query.cgi index 54362fabde..b9a0c34d64 100755 --- a/query.cgi +++ b/query.cgi @@ -437,7 +437,7 @@ changed. Program: Version: -Component: +Component: "; if (Param("usetargetmilestone")) { @@ -509,7 +509,6 @@ print " - "; StringSearch("Summary", "short_desc"); @@ -560,7 +559,6 @@ print "
Give me a clue about how to use this form. - "; diff --git a/show_bug.cgi b/show_bug.cgi index b2e7472972..927d526886 100755 --- a/show_bug.cgi +++ b/show_bug.cgi @@ -52,3 +52,6 @@ print "
\n"; $! = 0; do "bug_form.pl" || die "Error doing bug_form.pl: $!"; +print ""; +print "\n"; +