From: James Jones <jejones3141@gmail.com>
Date: Mon, 9 May 2022 21:38:14 +0000 (-0500)
Subject: Correct MEM() check of fr_pair_value_mem_alloc() return value (#4497)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a5ad3098d0369c4ce28e538d336925e46aac5337;p=thirdparty%2Ffreeradius-server.git

Correct MEM() check of fr_pair_value_mem_alloc() return value (#4497)
---

diff --git a/src/modules/rlm_ocsp/ocsp.c b/src/modules/rlm_ocsp/ocsp.c
index a3b36464a94..ba06a064758 100644
--- a/src/modules/rlm_ocsp/ocsp.c
+++ b/src/modules/rlm_ocsp/ocsp.c
@@ -157,7 +157,7 @@ static int ocsp_staple_to_pair(fr_pair_t **out, request_t *request, OCSP_RESPONS
 	}
 
 	MEM(pair_update_request(&vp, attr_tls_ocsp_response) >= 0);
-	MEM(fr_pair_value_mem_alloc(vp, &p, len, true));
+	MEM(fr_pair_value_mem_alloc(vp, &p, len, true) == 0);
 	len = i2d_OCSP_RESPONSE(resp, &p);
 	if (len <= 0) {
 		REDEBUG("Failed serialising OCSP response");