From: dklawren <dklawren@users.noreply.github.com>
Date: Fri, 11 May 2018 16:13:35 +0000 (-0400)
Subject: Bug 1460466 - Phab bot does not create r+ for acceptance when there are still blockin... 
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a5b780358d0e8c9cd611a644b3d6168daac711e3;p=thirdparty%2Fbugzilla.git

Bug 1460466 - Phab bot does not create r+ for acceptance when there are still blocking reviewers
---

diff --git a/extensions/PhabBugz/lib/Feed.pm b/extensions/PhabBugz/lib/Feed.pm
index 821ec6527..a0012cc10 100644
--- a/extensions/PhabBugz/lib/Feed.pm
+++ b/extensions/PhabBugz/lib/Feed.pm
@@ -412,11 +412,9 @@ sub process_revision_change {
     # REVIEWER STATUSES
 
     my (@accepted_phids, @denied_phids, @accepted_user_ids, @denied_user_ids);
-    unless ($revision->status eq 'changes-planned' || $revision->status eq 'needs-review') {
-        foreach my $reviewer (@{ $revision->reviewers }) {
-            push(@accepted_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'accepted';
-            push(@denied_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'rejected';
-        }
+    foreach my $reviewer (@{ $revision->reviewers }) {
+        push(@accepted_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'accepted';
+        push(@denied_phids, $reviewer->phab_phid) if $reviewer->phab_review_status eq 'rejected';
     }
 
     my $phab_users = get_phab_bmo_ids({ phids => \@accepted_phids });