From: Jeremy Allison Date: Thu, 4 Jun 2020 04:15:43 +0000 (-0700) Subject: s3: libsmb: SMBC_chmod_ctx(), rename mode -> attr when setting attributes. X-Git-Tag: ldb-2.2.0~221 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a5f5cbc25ee63ba5a0204dc23b249b4479d35de5;p=thirdparty%2Fsamba.git s3: libsmb: SMBC_chmod_ctx(), rename mode -> attr when setting attributes. Signed-off-by: Jeremy Allison Reviewed-by: Volker Lendecke --- diff --git a/source3/libsmb/libsmb_dir.c b/source3/libsmb/libsmb_dir.c index cdae281af19..cb0378290f8 100644 --- a/source3/libsmb/libsmb_dir.c +++ b/source3/libsmb/libsmb_dir.c @@ -1957,7 +1957,7 @@ SMBC_chmod_ctx(SMBCCTX *context, char *targetpath = NULL; struct cli_state *targetcli = NULL; char *path = NULL; - uint16_t mode; + uint16_t attr; uint16_t port = 0; TALLOC_CTX *frame = talloc_stackframe(); NTSTATUS status; @@ -2020,14 +2020,14 @@ SMBC_chmod_ctx(SMBCCTX *context, return -1; } - mode = 0; + attr = 0; - if (!(newmode & (S_IWUSR | S_IWGRP | S_IWOTH))) mode |= FILE_ATTRIBUTE_READONLY; - if ((newmode & S_IXUSR) && lp_map_archive(-1)) mode |= FILE_ATTRIBUTE_ARCHIVE; - if ((newmode & S_IXGRP) && lp_map_system(-1)) mode |= FILE_ATTRIBUTE_SYSTEM; - if ((newmode & S_IXOTH) && lp_map_hidden(-1)) mode |= FILE_ATTRIBUTE_HIDDEN; + if (!(newmode & (S_IWUSR | S_IWGRP | S_IWOTH))) attr |= FILE_ATTRIBUTE_READONLY; + if ((newmode & S_IXUSR) && lp_map_archive(-1)) attr |= FILE_ATTRIBUTE_ARCHIVE; + if ((newmode & S_IXGRP) && lp_map_system(-1)) attr |= FILE_ATTRIBUTE_SYSTEM; + if ((newmode & S_IXOTH) && lp_map_hidden(-1)) attr |= FILE_ATTRIBUTE_HIDDEN; - if (!NT_STATUS_IS_OK(cli_setatr(targetcli, targetpath, mode, 0))) { + if (!NT_STATUS_IS_OK(cli_setatr(targetcli, targetpath, attr, 0))) { errno = SMBC_errno(context, targetcli); TALLOC_FREE(frame); return -1;