From: Naoya Horiguchi Date: Fri, 13 Dec 2013 01:12:19 +0000 (-0800) Subject: include/linux/hugetlb.h: make isolate_huge_page() an inline X-Git-Tag: v3.12.40~135 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a5ff308f459c531704a133e1816cd80447c33329;p=thirdparty%2Fkernel%2Fstable.git include/linux/hugetlb.h: make isolate_huge_page() an inline commit f40386a4e976acb2bd3e0f9ead11e8e769acbe98 upstream. With CONFIG_HUGETLBFS=n: mm/migrate.c: In function `do_move_page_to_node_array': include/linux/hugetlb.h:140:33: warning: statement with no effect [-Wunused-value] #define isolate_huge_page(p, l) false ^ mm/migrate.c:1170:4: note: in expansion of macro `isolate_huge_page' isolate_huge_page(page, &pagelist); Reported-by: Borislav Petkov Tested-by: Borislav Petkov Signed-off-by: Naoya Horiguchi Acked-by: David Rientjes Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Jiri Slaby --- diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index e492c34439c3c..7e8e0001f241f 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -143,7 +143,10 @@ static inline int dequeue_hwpoisoned_huge_page(struct page *page) return 0; } -#define isolate_huge_page(p, l) false +static inline bool isolate_huge_page(struct page *page, struct list_head *list) +{ + return false; +} #define putback_active_hugepage(p) do {} while (0) #define is_hugepage_active(x) false static inline void copy_huge_page(struct page *dst, struct page *src)