From: Matt Jordan <mjordan@digium.com>
Date: Sat, 3 Sep 2016 21:02:37 +0000 (-0500)
Subject: apps/app_dial: Set the DIALSTATUS to NOANSWER on privacy option 5
X-Git-Tag: 13.12.0-rc1~63^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a64063cc9720637c1f54f85bb48d54b0e0ae8d3d;p=thirdparty%2Fasterisk.git

apps/app_dial: Set the DIALSTATUS to NOANSWER on privacy option 5

If the callee selects option '5' using the Dial application's privacy
(P) option, the DIALSTATUS is erroneously set to ANSWER. This option
reflects the callee sending the caller to VoiceMail one time; the call
is definitely *not* ANSWERed in such a scenario. With this patch, the
DIALSTATUS is instead set to NOANSWER, which is the same DIALSTATUS that
is set when the 'send to VoiceMail every time' option is set.

ASTERISK-25691

Change-Id: Iaf0c9f0fa00545e7366443875e2bb7d9a89a1358
---

diff --git a/apps/app_dial.c b/apps/app_dial.c
index c2484a2f3f..de6fe1852d 100644
--- a/apps/app_dial.c
+++ b/apps/app_dial.c
@@ -1914,9 +1914,10 @@ static int do_privacy(struct ast_channel *chan, struct ast_channel *peer,
 		ast_copy_string(pa->status, "DONTCALL", sizeof(pa->status));
 		break;
 	case '5':
-		/* XXX should we set status to DENY ? */
-		if (ast_test_flag64(opts, OPT_PRIVACY))
+		if (ast_test_flag64(opts, OPT_PRIVACY)) {
+			ast_copy_string(pa->status, "NOANSWER", sizeof(pa->status));
 			break;
+		}
 		/* if not privacy, then 5 is the same as "default" case */
 	default: /* bad input or -1 if failure to start autoservice */
 		/* well, if the user messes up, ... he had his chance... What Is The Best Thing To Do?  */