From: Nick Mathewson <nickm@torproject.org>
Date: Thu, 21 Aug 2014 15:05:59 +0000 (-0400)
Subject: Mark one use of networkstatus_check_document_signature as (void)
X-Git-Tag: tor-0.2.6.1-alpha~189^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a66fff6381abc5e3a70bd9cf3108560ed79f8d3e;p=thirdparty%2Ftor.git

Mark one use of networkstatus_check_document_signature as (void)

Also explain why we aren't checking its return value.

[CID 1198197]
---

diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index 6536b7fe99..cf6b88eb31 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -2273,8 +2273,11 @@ networkstatus_add_detached_signatures(networkstatus_t *target,
     if (!sig->good_signature && !sig->bad_signature) {
       cert = authority_cert_get_by_digests(sig->identity_digest,
                                            sig->signing_key_digest);
-      if (cert)
-        networkstatus_check_document_signature(target, sig, cert);
+      if (cert) {
+        /* Not checking the return value here, since we are going to look
+         * at the status of sig->good_signature in a moment. */
+        (void) networkstatus_check_document_signature(target, sig, cert);
+      }
     }
 
     /* If this signature is good, or we don't have any signature yet,