From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 22 Oct 2023 14:31:23 +0000 (-0400)
Subject: remove tests which are no longer necessary
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a6975aa11846f47c5ba2d3d64e224e353e3d9bed;p=thirdparty%2Ffreeradius-server.git

remove tests which are no longer necessary

we don't support cross-protocol attributes
---

diff --git a/src/tests/keywords/all.mk b/src/tests/keywords/all.mk
index af7ebfeddf3..d304b784229 100644
--- a/src/tests/keywords/all.mk
+++ b/src/tests/keywords/all.mk
@@ -65,7 +65,7 @@ endif
 #
 
 #  Tests for the "update" keyword
-KEYWORD_UPDATE_TESTS := update-attr-ref-null update-error-3 update-group-error update-null-value-assign update-remove-index update-filter update-proto update-proto-error vendor-specific-error comments smash
+KEYWORD_UPDATE_TESTS := update-attr-ref-null update-error-3 update-group-error update-null-value-assign update-remove-index update-filter vendor-specific-error 
 
 # Tests for rewriting "udpate"
 KEYWORD_UPDATE_REWRITE_TESTS := update-all update-array update-delete update-remove-any update-group update-hex update-remove-value update-index update-list-error update-remove-list update-prepend unknown-update update-error update-error-2 update-exec-error update-list-null-rhs update-exec
diff --git a/src/tests/keywords/comments b/src/tests/keywords/comments
deleted file mode 100644
index bfb568b4019..00000000000
--- a/src/tests/keywords/comments
+++ /dev/null
@@ -1,45 +0,0 @@
-#
-#  PRE: if
-#
-
-# One comment
-#{ Two comment
-#} Three comment
-#'Four'
-#"Five comment"
-##Six Comment#
-	#Seven comment (yes i'm meant to be tabbed in)
-  #Eight comment (yes i'm meant to have spaces before me)
- 	#Nine comment (tabs and spaces, are you crazy?!)
-
-update {					#}'{ Opening block with extra special chars {} '"
-	&control.User-Name := 'whatever'		# do some random stuff
-}						#{'} Closing block with extra special chars {} '"
-
-update { &Tmp-String-0 := 'candy' }	# Comment after unicorn block
-
-&request += {
-	&Reply-Message = 'I am #literally a comment #'
-}
-&request += {
-	&Reply-Message = "I am #literally a comment #"
-}
-
-if (!(&Tmp-String-0 == 'candy')) {
-	test_fail
-}
-
-if !(&request.Reply-Message[0] == 'I am #literally a comment #') {
-	test_fail
-}
-
-if (!(&request.Reply-Message[1] == "I am #literally a comment #")) {
-	test_fail
-}
-
-ok # I'm a comment after a module call
-ok # I'm a comment # after a module {} call
-
-ok, ok, ok, ok, ok
-
-success
diff --git a/src/tests/keywords/smash b/src/tests/keywords/smash
deleted file mode 100644
index 3b79a13d098..00000000000
--- a/src/tests/keywords/smash
+++ /dev/null
@@ -1,8 +0,0 @@
-#
-#  PRE: update
-#
-#  This gives the game away.
-#
-update { &control.User-Name := 'bob', &Reply-Message := "foo" }
-
-success
diff --git a/src/tests/keywords/update-proto b/src/tests/keywords/update-proto
deleted file mode 100644
index 47bbe2236c3..00000000000
--- a/src/tests/keywords/update-proto
+++ /dev/null
@@ -1,11 +0,0 @@
-#
-#  PROTOCOL: dhcpv4
-#
-#  Not really, but it's a way to test cross-protocol issues
-#
-update {
-	&Proto.radius.User-Name = 'uid'
-	&Password.With-Header = 'userPassword'
-}
-
-success
diff --git a/src/tests/keywords/update-proto-error b/src/tests/keywords/update-proto-error
deleted file mode 100644
index 90637dc755b..00000000000
--- a/src/tests/keywords/update-proto-error
+++ /dev/null
@@ -1,11 +0,0 @@
-#
-#  PROTOCOL: dhcpv4
-#
-#  We cannot refer to internal attributes by number
-#  Those numbers don't mean anything.
-#
-update {
-	&Proto.1.User-Name += 'foo'	# ERROR
-}
-
-success