From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 21 Nov 2023 07:44:47 +0000 (+0100)
Subject: sdig: Fix Coverity 1524951: copy instead of move
X-Git-Tag: rec-5.0.0-rc1~3^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a69c873bcb921f19f698177d4e0274393eb21455;p=thirdparty%2Fpdns.git

sdig: Fix Coverity 1524951: copy instead of move
---

diff --git a/pdns/sdig.cc b/pdns/sdig.cc
index 60d14b6bfe..a9ee11182a 100644
--- a/pdns/sdig.cc
+++ b/pdns/sdig.cc
@@ -58,7 +58,7 @@ static const string nameForClass(QClass qclass, uint16_t qtype)
 static std::unordered_set<uint16_t> s_expectedIDs;
 
 static void fillPacket(vector<uint8_t>& packet, const string& q, const string& t,
-                       bool dnssec, const boost::optional<Netmask> ednsnm,
+                       bool dnssec, const boost::optional<Netmask>& ednsnm,
                        bool recurse, uint16_t xpfcode, uint16_t xpfversion,
                        uint64_t xpfproto, char* xpfsrc, char* xpfdst,
                        QClass qclass, uint8_t opcode, uint16_t qid)