From: Jukka Kurkela <jukka.kurkela@gmail.com>
Date: Tue, 16 Feb 2021 15:26:22 +0000 (+0200)
Subject: Fix memory leak on destroy (#8438)
X-Git-Tag: v3.0.0-beta.11~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a6a12282c49e006d3a6fc06297f39b84fe409deb;p=thirdparty%2FChart.js.git

Fix memory leak on destroy (#8438)
---

diff --git a/src/core/core.config.js b/src/core/core.config.js
index a0562faad..309cf75fc 100644
--- a/src/core/core.config.js
+++ b/src/core/core.config.js
@@ -156,9 +156,13 @@ export default class Config {
 
   update(options) {
     const config = this._config;
+    this.clearCache();
+    config.options = initOptions(config, options);
+  }
+
+  clearCache() {
     this._scopeCache.clear();
     this._resolverCache.clear();
-    config.options = initOptions(config, options);
   }
 
   /**
diff --git a/src/core/core.controller.js b/src/core/core.controller.js
index b84b22c33..3e9151a0f 100644
--- a/src/core/core.controller.js
+++ b/src/core/core.controller.js
@@ -831,6 +831,8 @@ class Chart {
       me._destroyDatasetMeta(i);
     }
 
+    me.config.clearCache();
+
     if (canvas) {
       me.unbindEvents();
       clearCanvas(canvas, ctx);