From: Aram Sargsyan <aram@isc.org>
Date: Mon, 25 Mar 2024 14:20:24 +0000 (+0000)
Subject: Remove a redundant log message and a comment
X-Git-Tag: v9.19.23~5^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a6c6ad048da64a7435ec3fea8cb69f7431084ee0;p=thirdparty%2Fbind9.git

Remove a redundant log message and a comment

If val->result is not ISC_R_SUCCESS, a similar message is logged
further down in the function. Remove the redundant log message.

Also remove an unnecessary code comment line.
---

diff --git a/lib/dns/validator.c b/lib/dns/validator.c
index 5681c89a367..d80c22b04cf 100644
--- a/lib/dns/validator.c
+++ b/lib/dns/validator.c
@@ -1638,11 +1638,7 @@ validate_answer_finish(void *arg) {
 	dns_validator_t *val = arg;
 	isc_result_t result = ISC_R_UNSET;
 
-	if (val->result != ISC_R_SUCCESS) {
-		validator_log(val, ISC_LOG_DEBUG(3),
-			      "failed to verify rdataset: %s",
-			      isc_result_totext(val->result));
-	} else {
+	if (val->result == ISC_R_SUCCESS) {
 		dns_rdataset_trimttl(val->rdataset, val->sigrdataset,
 				     val->siginfo, val->start,
 				     val->view->acceptexpired);
@@ -1659,7 +1655,6 @@ validate_answer_finish(void *arg) {
 
 	switch (val->result) {
 	case ISC_R_CANCELED:
-		/* The validation was canceled */
 		validator_log(val, ISC_LOG_DEBUG(3), "validation was canceled");
 		validate_async_done(val, val->result);
 		return;