From: Ulf Hermann <ulf.hermann@qt.io>
Date: Thu, 20 Apr 2017 14:57:41 +0000 (+0200)
Subject: On elf_update, remember when we mmap()
X-Git-Tag: elfutils-0.169~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a6c6fb4ae497a086e75f9436b67a1de4564bfb91;p=thirdparty%2Felfutils.git

On elf_update, remember when we mmap()

Otherwise we skip the munmap() later. This leaks resources.

Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>
---

diff --git a/libelf/ChangeLog b/libelf/ChangeLog
index d425e50a7..4f232289a 100644
--- a/libelf/ChangeLog
+++ b/libelf/ChangeLog
@@ -1,3 +1,7 @@
+2017-04-20  Ulf Hermann  <ulf.hermann@qt.io>
+
+	* elf_update.c: Set ELF_F_MMAPPED flag if we mmap from elf_update.
+
 2017-04-19  Mark Wielaard  <mark@klomp.org>
 
 	* elf_getarsym.c (elf_getarsym): Initialize n to zero.
diff --git a/libelf/elf_update.c b/libelf/elf_update.c
index c635eb328..8ce078291 100644
--- a/libelf/elf_update.c
+++ b/libelf/elf_update.c
@@ -74,6 +74,8 @@ write_file (Elf *elf, off_t size, int change_bo, size_t shnum)
 			       MAP_SHARED, elf->fildes, 0);
       if (unlikely (elf->map_address == MAP_FAILED))
 	elf->map_address = NULL;
+      else
+	elf->flags |= ELF_F_MMAPPED;
     }
 
   if (elf->map_address != NULL)