From: John Ferlan <jferlan@redhat.com>
Date: Sun, 3 Nov 2019 12:34:04 +0000 (-0500)
Subject: tests: Remove _NULLABLE in virNetDevExists mock
X-Git-Tag: v5.10.0-rc1~406
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a6ce760f6b3dce5ca76bff23c1e7d156433c0c69;p=thirdparty%2Flibvirt.git

tests: Remove _NULLABLE in virNetDevExists mock

The @ifname is listed as an ATTRIBUTE_NONNULL(1) parameter, so
checking for _NULLABLE causes a coverity build failure - remove
that and if it's NULL for the test let's fail miserably.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c
index 914d2bcf9f..8143de1618 100644
--- a/tests/qemuxml2argvmock.c
+++ b/tests/qemuxml2argvmock.c
@@ -169,7 +169,7 @@ virNetDevSetMAC(const char *ifname G_GNUC_UNUSED,
 int
 virNetDevExists(const char *ifname)
 {
-    return STREQ_NULLABLE(ifname, "mytap0");
+    return STREQ(ifname, "mytap0");
 }