From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 22 Dec 2023 16:37:20 +0000 (+0100)
Subject: dnsdist: Delint DoQ and DoH3
X-Git-Tag: auth-4.9.0-alpha1~18^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a6cfab84c108aa0a6053a1556eba41c55726eee0;p=thirdparty%2Fpdns.git

dnsdist: Delint DoQ and DoH3
---

diff --git a/pdns/dnsdistdist/doh3.cc b/pdns/dnsdistdist/doh3.cc
index 3f724ff7e8..e4ce44827c 100644
--- a/pdns/dnsdistdist/doh3.cc
+++ b/pdns/dnsdistdist/doh3.cc
@@ -810,7 +810,7 @@ static void handleSocketReadable(DOH3Frontend& frontend, ClientState& clientStat
   while (true) {
     ComboAddress client;
     buffer.resize(4096);
-    if (!sock.recvFromAsync(buffer, client) || buffer.size() == 0) {
+    if (!sock.recvFromAsync(buffer, client) || buffer.empty()) {
       return;
     }
     DEBUGLOG("Received DoH3 datagram of size "<<buffer.size()<<" from "<<client.toStringWithPort());
diff --git a/pdns/dnsdistdist/doq.cc b/pdns/dnsdistdist/doq.cc
index 26c967d840..673ace0d2c 100644
--- a/pdns/dnsdistdist/doq.cc
+++ b/pdns/dnsdistdist/doq.cc
@@ -593,7 +593,7 @@ static void handleReadableStream(DOQFrontend& frontend, ClientState& clientState
       streamBuffer.resize(existingLength);
       return;
     }
-    else if (received < 0) {
+    if (received < 0) {
       ++dnsdist::metrics::g_stats.nonCompliantQueries;
       ++clientState.nonCompliantQueries;
       quiche_conn_stream_shutdown(conn.d_conn.get(), streamID, QUICHE_SHUTDOWN_WRITE, static_cast<uint64_t>(DOQ_Error_Codes::DOQ_PROTOCOL_ERROR));
@@ -631,7 +631,7 @@ static void handleSocketReadable(DOQFrontend& frontend, ClientState& clientState
   while (true) {
     ComboAddress client;
     buffer.resize(4096);
-    if (!sock.recvFromAsync(buffer, client) || buffer.size() == 0) {
+    if (!sock.recvFromAsync(buffer, client) || buffer.empty()) {
       return;
     }
     DEBUGLOG("Received DoQ datagram of size "<<buffer.size()<<" from "<<client.toStringWithPort());