From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Sun, 17 Mar 2024 21:15:21 +0000 (+0200)
Subject: lib-settings: Ignore duplicate named list filter entries
X-Git-Tag: 2.4.1~917
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a6f20d84d6758b9f60e257516a32f0757a663444;p=thirdparty%2Fdovecot%2Fcore.git

lib-settings: Ignore duplicate named list filter entries

These can happen when some filters override settings for existing named list
filters.
---

diff --git a/src/lib-settings/settings-parser.c b/src/lib-settings/settings-parser.c
index 64d813c1e2..b8a6b5acd7 100644
--- a/src/lib-settings/settings-parser.c
+++ b/src/lib-settings/settings-parser.c
@@ -698,6 +698,8 @@ settings_parse(struct setting_parser_context *ctx,
 		for (i = 0; i < count; i++) {
 			const char *value = p_strdup(ctx->set_pool,
 				settings_section_unescape(list[i]));
+			if (array_lsearch(arr, &value, i_strcmp_p) != NULL)
+				continue; /* ignore duplicates */
 			if ((ctx->flags & SETTINGS_PARSER_FLAG_INSERT_FILTERS) != 0)
 				array_insert(arr, insert_pos++, &value, 1);
 			else