From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 6 Apr 2021 00:38:29 +0000 (+0100)
Subject: Interpret signal marks the request as done
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a70d47a2a045ceadb87098a7c1e0f19e004ee0f0;p=thirdparty%2Ffreeradius-server.git

Interpret signal marks the request as done
---

diff --git a/src/lib/unlang/parallel.c b/src/lib/unlang/parallel.c
index 8e06c2ed7a..4d3a4796f8 100644
--- a/src/lib/unlang/parallel.c
+++ b/src/lib/unlang/parallel.c
@@ -54,14 +54,13 @@ static inline CC_HINT(always_inline) void unlang_parallel_cancel_child(unlang_pa
 	case CHILD_RUNNABLE:	/* Don't check runnable_id, may be yielded */
 		/*
 		 *	Signal the child to stop
+		 *
+		 *	The signal function cleans up the request
+		 *	and signals anything that was tracking it
+		 *	that it's now complete.
 		 */
 		unlang_interpret_signal(child, FR_SIGNAL_CANCEL);
 
-		/*
-		 *	Remove it from the runnable heap
-		 */
-		unlang_interpret_request_done(child);
-
 		/*
 		 *	Free it.
 		 */