From: Volker Lendecke <vl@samba.org>
Date: Fri, 5 Jun 2009 22:46:38 +0000 (+0200)
Subject: Fix an uninitialized variable read in async_connect_send
X-Git-Tag: tdb-1.1.5~245
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a731eb64d9a9415d5df2a385326cc14fcd4481eb;p=thirdparty%2Fsamba.git

Fix an uninitialized variable read in async_connect_send
---

diff --git a/lib/async_req/async_sock.c b/lib/async_req/async_sock.c
index a505fcf4656..643eb2d308f 100644
--- a/lib/async_req/async_sock.c
+++ b/lib/async_req/async_sock.c
@@ -223,6 +223,11 @@ struct tevent_req *async_connect_send(TALLOC_CTX *mem_ctx,
 	state->fd = fd;
 	state->sys_errno = 0;
 
+	state->old_sockflags = fcntl(fd, F_GETFL, 0);
+	if (state->old_sockflags == -1) {
+		goto post_errno;
+	}
+
 	state->address_len = address_len;
 	if (address_len > sizeof(state->address)) {
 		errno = EINVAL;
@@ -230,11 +235,6 @@ struct tevent_req *async_connect_send(TALLOC_CTX *mem_ctx,
 	}
 	memcpy(&state->address, address, address_len);
 
-	state->old_sockflags = fcntl(fd, F_GETFL, 0);
-	if (state->old_sockflags == -1) {
-		goto post_errno;
-	}
-
 	set_blocking(fd, false);
 
 	state->result = connect(fd, address, address_len);