From: Ralph Boehme Date: Sun, 23 Dec 2018 08:12:34 +0000 (+0100) Subject: Revert "pthreadpool: ignore the return value of poll(NULL, 0UL, 1)" X-Git-Tag: talloc-2.1.15~197 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a75f5de15dba1c9f41a2d86c4fa6573764d4cb8d;p=thirdparty%2Fsamba.git Revert "pthreadpool: ignore the return value of poll(NULL, 0UL, 1)" This reverts commit 6da0d68f49bbd82f5a08427779c9f5ebd6f755aa. See the discussion in https://lists.samba.org/archive/samba-technical/2018-December/131731.html for the reasoning behind this revert. Signed-off-by: Ralph Boehme Reviewed-by: Volker Lendecke Reviewed-by: Stefan Metzmacher --- diff --git a/lib/pthreadpool/pthreadpool_tevent.c b/lib/pthreadpool/pthreadpool_tevent.c index 7088202d97c..b4a9786f231 100644 --- a/lib/pthreadpool/pthreadpool_tevent.c +++ b/lib/pthreadpool/pthreadpool_tevent.c @@ -873,7 +873,7 @@ static void pthreadpool_tevent_job_orphan(struct pthreadpool_tevent_job *job) */ PTHREAD_TEVENT_JOB_THREAD_FENCE(job); while (job->needs_fence.wrapper) { - (void)poll(NULL, 0, 1); + poll(NULL, 0, 1); PTHREAD_TEVENT_JOB_THREAD_FENCE(job); } job->wrapper = NULL; @@ -903,7 +903,7 @@ static void pthreadpool_tevent_job_orphan(struct pthreadpool_tevent_job *job) if (job->needs_fence.signaled) { break; } - (void)poll(NULL, 0, 1); + poll(NULL, 0, 1); PTHREAD_TEVENT_JOB_THREAD_FENCE(job); }