From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 12 Jun 2025 20:51:46 +0000 (-0700)
Subject: factor: use mpz_probab_prime_p
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a76600cda23a95497c8266368d4837ba828aab8e;p=thirdparty%2Fcoreutils.git

factor: use mpz_probab_prime_p

Inspired by a proposal by Torbjörn Granlund in:
https://lists.gnu.org/r/coreutils/2025-01/msg00000.html
* src/factor.c (mp_prime_p): Use mpz_probab_prime_p rather than doing
it by hand, as mpz_probab_prime_p uses Baillie-PSW which is a win.
This removes the need for the ret2 label and goto.
---

diff --git a/src/factor.c b/src/factor.c
index 97c14695c4..0542c0e6f1 100644
--- a/src/factor.c
+++ b/src/factor.c
@@ -1449,7 +1449,6 @@ mp_prime_p (mpz_t n)
 {
   bool is_prime;
   mpz_t q, a, nm1, tmp;
-  struct mp_factors factors;
 
   if (mpz_cmp_ui (n, 1) <= 0)
     return false;
@@ -1458,6 +1457,12 @@ mp_prime_p (mpz_t n)
   if (mpz_cmp_ui (n, (long) FIRST_OMITTED_PRIME * FIRST_OMITTED_PRIME) < 0)
     return true;
 
+  int probab_prime = mpz_probab_prime_p (n, MR_REPS);
+  if (probab_prime == 0)
+    return false;
+  if (flag_prove_primality < probab_prime)
+    return true;
+
   mpz_inits (q, a, nm1, tmp, nullptr);
 
   /* Precomputation for Miller-Rabin.  */
@@ -1469,38 +1474,20 @@ mp_prime_p (mpz_t n)
 
   mpz_set_ui (a, 2);
 
-  /* Perform a Miller-Rabin test, finds most composites quickly.  */
-  if (!mp_millerrabin (n, nm1, a, tmp, q, k))
-    {
-      is_prime = false;
-      goto ret2;
-    }
-
-  if (flag_prove_primality)
-    {
-      /* Factor n-1 for Lucas.  */
-      mpz_set (tmp, nm1);
-      factors = mp_factor (tmp);
-    }
+  /* Factor n-1 for Lucas.  */
+  mpz_set (tmp, nm1);
+  struct mp_factors factors = mp_factor (tmp);
 
   /* Loop until Lucas proves our number prime, or Miller-Rabin proves our
      number composite.  */
   for (idx_t r = 0; ; r++)
     {
-      if (flag_prove_primality)
+      is_prime = true;
+      for (idx_t i = 0; i < factors.nfactors && is_prime; i++)
         {
-          is_prime = true;
-          for (idx_t i = 0; i < factors.nfactors && is_prime; i++)
-            {
-              mpz_divexact (tmp, nm1, factors.f[i].p);
-              mpz_powm (tmp, a, tmp, n);
-              is_prime = mpz_cmp_ui (tmp, 1) != 0;
-            }
-        }
-      else
-        {
-          /* After enough Miller-Rabin runs, be content.  */
-          is_prime = (r == MR_REPS - 1);
+          mpz_divexact (tmp, nm1, factors.f[i].p);
+          mpz_powm (tmp, a, tmp, n);
+          is_prime = mpz_cmp_ui (tmp, 1) != 0;
         }
 
       if (is_prime)
@@ -1518,11 +1505,8 @@ mp_prime_p (mpz_t n)
         }
     }
 
-  if (flag_prove_primality)
-    mp_factor_clear (&factors);
- ret2:
+  mp_factor_clear (&factors);
   mpz_clears (q, a, nm1, tmp, nullptr);
-
   return is_prime;
 }