From: bert hubert <bert.hubert@netherlabs.nl>
Date: Sun, 6 Mar 2016 09:58:37 +0000 (+0100)
Subject: clarify a deficiency in our packet hashing in the presence of EDNS subnet options
X-Git-Tag: rec-4.0.0-alpha2~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a774e78b536547aebc1d358c0bb8a1aaee8c39f8;p=thirdparty%2Fpdns.git

clarify a deficiency in our packet hashing in the presence of EDNS subnet options
---

diff --git a/pdns/recpacketcache.cc b/pdns/recpacketcache.cc
index 68a4f3640d..73756cd8e1 100644
--- a/pdns/recpacketcache.cc
+++ b/pdns/recpacketcache.cc
@@ -47,7 +47,7 @@ static bool qrMatch(const std::string& query, const std::string& response)
   uint16_t rqtype, rqclass, qqtype, qqclass;
   DNSName queryname(query.c_str(), query.length(), sizeof(dnsheader), false, &qqtype, &qqclass, 0);
   DNSName respname(response.c_str(), response.length(), sizeof(dnsheader), false, &rqtype, &rqclass, 0);
-  
+  // this ignores checking on the EDNS subnet flags! 
   return queryname==respname && rqtype == qqtype && rqclass == qqclass;
 }