From: Karel Zak <kzak@redhat.com>
Date: Wed, 27 Mar 2013 15:22:56 +0000 (+0100)
Subject: setterm: fix memory leak [coverity scan]
X-Git-Tag: v2.23-rc2~90
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a77e7ac77c0bb8e7fd56aa04d6645aef11f8f56c;p=thirdparty%2Futil-linux.git

setterm: fix memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/term-utils/setterm.c b/term-utils/setterm.c
index c456048d92..0e72cf0532 100644
--- a/term-utils/setterm.c
+++ b/term-utils/setterm.c
@@ -1160,7 +1160,7 @@ screendump(int vcnum, FILE * F)
 	int fd;
 	size_t i, j;
 	ssize_t rc;
-	char *inbuf, *outbuf, *p, *q;
+	char *inbuf = NULL, *outbuf = NULL, *p, *q;
 
 	sprintf(infile, "/dev/vcsa%d", vcnum);
 	fd = open(infile, O_RDONLY);
@@ -1208,6 +1208,8 @@ screendump(int vcnum, FILE * F)
 		goto error;
 	}
 	close(fd);
+	free(inbuf);
+	free(outbuf);
 	return;
 
 read_error:
@@ -1219,6 +1221,8 @@ read_error:
 error:
 	if (fd >= 0)
 		close(fd);
+	free(inbuf);
+	free(outbuf);
 	exit(EXIT_FAILURE);
 }