From: Volker Lendecke <vl@samba.org>
Date: Sat, 13 Sep 2025 20:34:00 +0000 (+0200)
Subject: smbd: Reduce indentation in smb2_parse_file_rename_information()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a7810d2317ee5962499d4159d7dbe53a4ee444a5;p=thirdparty%2Fsamba.git

smbd: Reduce indentation in smb2_parse_file_rename_information()

Avoid an "else"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/smb2_trans2.c b/source3/smbd/smb2_trans2.c
index 99e4a8b6571..1801bca00fd 100644
--- a/source3/smbd/smb2_trans2.c
+++ b/source3/smbd/smb2_trans2.c
@@ -4341,17 +4341,17 @@ NTSTATUS smb2_parse_file_rename_information(TALLOC_CTX *ctx,
 			return NT_STATUS_NO_MEMORY;
 		}
 		goto done;
-	} else {
-		status = filename_convert_dirfsp(ctx,
-						 conn,
-						 newname,
-						 ucf_flags,
-						 0, /* Never a TWRP. */
-						 &dst_dirfsp,
-						 &smb_fname_dst);
-		if (!NT_STATUS_IS_OK(status)) {
-			return status;
-		}
+	}
+
+	status = filename_convert_dirfsp(ctx,
+					 conn,
+					 newname,
+					 ucf_flags,
+					 0, /* Never a TWRP. */
+					 &dst_dirfsp,
+					 &smb_fname_dst);
+	if (!NT_STATUS_IS_OK(status)) {
+		return status;
 	}
 
 	/*