From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Fri, 23 Jun 2017 22:15:30 +0000 (-0600)
Subject: Fixed message packing error handling in mgr and snmp SMP Forwarders.
X-Git-Tag: M-staged-PR71~101
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a7ba2ec1d8ee27707b7c8628ecf001318daef62e;p=thirdparty%2Fsquid.git

Fixed message packing error handling in mgr and snmp SMP Forwarders.

A missing "return" resulted in Forwarders sending garbage (or worse) to
Coordinator.
---

diff --git a/src/ipc/Forwarder.cc b/src/ipc/Forwarder.cc
index 13e051fff3..58a72915fa 100644
--- a/src/ipc/Forwarder.cc
+++ b/src/ipc/Forwarder.cc
@@ -62,6 +62,7 @@ Ipc::Forwarder::start()
         // assume the pack() call failed because the message did not fit
         // TODO: add a more specific exception?
         handleError();
+        return;
     }
 
     SendMessage(Ipc::Port::CoordinatorAddr(), message);