From: Mike Bayer Date: Tue, 15 Jan 2019 15:10:56 +0000 (-0500) Subject: PR template tweaks X-Git-Tag: rel_1_3_0b2~29 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a7d6cb13ac96f2abc9366f5ed26fd91cd69ac7cd;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git PR template tweaks Change-Id: I49557362057fef3ea151bc2f4bd8c3c96cdf5935 --- diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ce2f00321a..22c904f7d5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -13,26 +13,20 @@ This pull request is: - [ ] A documentation / typographical error fix - Good to go, no issue or tests are needed - [ ] A short code fix - - [ ] I have filed [a bug report](https://github.com/sqlalchemy/sqlalchemy/issues) which includes a complete [MCVE](http://stackoverflow.com/help/mcve) illustrating in simple code form the expected behavior and how the library deviates from it. This is necessary **no matter how obvious the problem and/or fix is**, because this is how we track the issue being repaired for users that need to know about it, as well as where the correct fix can be agreed upon - the problem you are fixing is more often than not more complicated than it seems. + - [ ] There is a bug report already, or I have filed [a bug report](https://github.com/sqlalchemy/sqlalchemy/issues) which includes a test case ([MCVE](http://stackoverflow.com/help/mcve)) illustrating in simple code form the expected behavior and how the library deviates from it. - [ ] My git commit includes a `Fixes: #` comment with the above bug report number - [ ] My code fix includes a unit test, which is typically based on the MCVE I did above - [ ] I then **ran the tests**, using the instructions at [README.unittests.rst](https://github.com/sqlalchemy/sqlalchemy/blob/master/README.unittests.rst) - [ ] I don't know how to write a test for this. In which case please FILE A BUG ONLY. - - Follow up availability: - - [ ] I **Will** be able to respond in a timely fashion to additional requests for changes and detail. - - [ ] I **Will Not** be able to respond in a timely fashion to additional requests for changes and detail. - - if you checked "Will Not", please FILE A BUG ONLY. + - [ ] I will be able to respond in a timely fashion to additional requests for changes and detail. - [ ] A new feature implementation - - [ ] I have filed [a bug report](https://github.com/sqlalchemy/sqlalchemy/issues) which includes a complete description of the new behavior, including an a Python code example that illustrates how the feature would work. + - [ ] There is a bug report already, or I have filed [a bug report](https://github.com/sqlalchemy/sqlalchemy/issues) which includes a complete description of the new behavior, including an a Python code example that illustrates how the feature would work. - [ ] The new feature request was **approved by SQLAlchemy maintainers** who requested that I submit a pull request. - [ ] My git commit includes a `Fixes: #` comment with the above bug report number - [ ] My code fix includes unit tests that assert the behavior is as expected. - [ ] I then **ran the tests**, using the instructions at [README.unittests.rst](https://github.com/sqlalchemy/sqlalchemy/blob/master/README.unittests.rst) - [ ] I don't know how to write the tests. in which case please GET HELP FROM THE MAINTAINERS on the above mentioned issue how tests for this feature should be structured. - - Follow up availability: - - [ ] I **Will** be able to respond in a timely fashion to additional requests for changes and detail. - - [ ] I **Will Not** be able to respond in a timely fashion to additional requests for changes and detail. - - if you checked "Will Not", please FILE A BUG ONLY. + - [ ] I will be able to respond in a timely fashion to additional requests for changes and detail.