From: Victor Julien <vjulien@oisf.net>
Date: Tue, 26 Apr 2022 18:18:28 +0000 (+0200)
Subject: reference: remove useless var reset
X-Git-Tag: suricata-5.0.10~63
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a7dbbc8caa079238ece5d6afcf3edec912c21ed5;p=thirdparty%2Fsuricata.git

reference: remove useless var reset

cppcheck:

src/util-reference-config.c:179:9: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg]
        fd = NULL;
        ^

Bug: #5291.
(cherry picked from commit 5a0bbb5289cd0fbf4ef50294127cb1018baf82a2)
---

diff --git a/src/util-reference-config.c b/src/util-reference-config.c
index df77a10d9e..fc0ff0f5df 100644
--- a/src/util-reference-config.c
+++ b/src/util-reference-config.c
@@ -179,7 +179,6 @@ static void SCRConfDeInitLocalResources(DetectEngineCtx *de_ctx, FILE *fd)
 {
     if (fd != NULL) {
         fclose(fd);
-        fd = NULL;
     }
 
     return;