From: Gary Lockyer <gary@catalyst.net.nz>
Date: Thu, 15 Jan 2026 03:08:22 +0000 (+1300)
Subject: s4:client:http_test fix Non-boolean returned
X-Git-Tag: tdb-1.4.15~61
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a7e7a68b80cbf7fec83e75cc592cda0bcdfb3766;p=thirdparty%2Fsamba.git

s4:client:http_test fix Non-boolean returned

fix cppcheck

source4/client/http_test.c:85:3: style: Non-boolean value returned from
    function returning bool [returnNonBoolInBooleanFunction]

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15924

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/source4/client/http_test.c b/source4/client/http_test.c
index 158b2d1a8df..b2c4c04cb85 100644
--- a/source4/client/http_test.c
+++ b/source4/client/http_test.c
@@ -82,7 +82,7 @@ static bool send_http_request(TALLOC_CTX *mem_ctx,
 				response_size);
 	if (!req) {
 		DBG_ERR("no memory\n");
-		return -1;
+		return false;
 	}
 
 	if (!tevent_req_set_endtime(req, ev_ctx, timeval_current_ofs(10, 0))) {