From: Joe Orton <jorton@apache.org>
Date: Tue, 10 Feb 2004 12:17:44 +0000 (+0000)
Subject: * modules/ssl/ssl_engine_pphrase.c: Note that the ERR_clear_error()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a7ef0ab0d8f6e12517451815c9c114403a7bf3a5;p=thirdparty%2Fapache%2Fhttpd.git

* modules/ssl/ssl_engine_pphrase.c: Note that the ERR_clear_error()
call is not merely a cosmetic fix in light of PR 21160.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@102628 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/ssl_engine_pphrase.c b/ssl_engine_pphrase.c
index 41ae57d66fe..d38de7ea2dc 100644
--- a/ssl_engine_pphrase.c
+++ b/ssl_engine_pphrase.c
@@ -340,8 +340,9 @@ void ssl_pphrase_Handle(server_rec *s, apr_pool_t *p)
                 cpPassPhraseCur = NULL;
                 ssl_pphrase_server_rec = s; /* to make up for sslc flaw */
 
-                /* Ensure that the error stack is empty; otherwise the
-                 * OpenSSL UI code may dump it to stderr. */
+                /* Ensure that the error stack is empty; some SSL
+                 * functions will fail spuriously if the error stack
+                 * is not empty. */
                 ERR_clear_error();
 
                 bReadable = ((pPrivateKey = SSL_read_PrivateKey(szPath, NULL,