From: Andrew Bartlett Date: Wed, 14 Jun 2017 02:13:18 +0000 (+1200) Subject: dsdb: Improve debug messages X-Git-Tag: ldb-1.1.31~63 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a7ef0f8be4bda18e3916bdbe8468bc1703060d94;p=thirdparty%2Fsamba.git dsdb: Improve debug messages Signed-off-by: Andrew Bartlett Reviewed-by: Garming Sam --- diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c index ce06ee89013..2715db84083 100644 --- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c +++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c @@ -4528,7 +4528,7 @@ static int replmd_name_modify(struct replmd_replicated_request *ar, DSDB_FLAG_OWN_MODULE|DSDB_FLAG_REPLICATED_UPDATE, req); if (ret != LDB_SUCCESS) { - DEBUG(0,(__location__ ": Failed to modify rDN/name of conflict DN '%s' - %s", + DEBUG(0,(__location__ ": Failed to modify rDN/name of DN being DRS renamed '%s' - %s", ldb_dn_get_linearized(dn), ldb_errstring(ldb_module_get_ctx(ar->module)))); return ret; @@ -4540,7 +4540,7 @@ static int replmd_name_modify(struct replmd_replicated_request *ar, failed: talloc_free(msg); - DEBUG(0,(__location__ ": Failed to setup modify rDN/name of conflict DN '%s'", + DEBUG(0,(__location__ ": Failed to setup modify rDN/name of DN being DRS renamed '%s'", ldb_dn_get_linearized(dn))); return LDB_ERR_OPERATIONS_ERROR; } diff --git a/source4/dsdb/samdb/ldb_modules/schema_data.c b/source4/dsdb/samdb/ldb_modules/schema_data.c index 996b1f22386..5362ef091c3 100644 --- a/source4/dsdb/samdb/ldb_modules/schema_data.c +++ b/source4/dsdb/samdb/ldb_modules/schema_data.c @@ -171,13 +171,13 @@ static int schema_data_add(struct ldb_module *module, struct ldb_request *req) if (!schema->fsmo.we_are_master && !rodc) { ldb_debug_set(ldb, LDB_DEBUG_ERROR, - "schema_data_add: we are not master: reject request\n"); + "schema_data_add: we are not master: reject add request\n"); return LDB_ERR_UNWILLING_TO_PERFORM; } if (!schema->fsmo.update_allowed && !rodc) { ldb_debug_set(ldb, LDB_DEBUG_ERROR, - "schema_data_add: updates are not allowed: reject request\n"); + "schema_data_add: updates are not allowed: reject add request\n"); return LDB_ERR_UNWILLING_TO_PERFORM; } @@ -333,13 +333,13 @@ static int schema_data_modify(struct ldb_module *module, struct ldb_request *req if (!schema->fsmo.we_are_master && !rodc) { ldb_debug_set(ldb, LDB_DEBUG_ERROR, - "schema_data_modify: we are not master: reject request\n"); + "schema_data_modify: we are not master: reject modify request\n"); return LDB_ERR_UNWILLING_TO_PERFORM; } if (!schema->fsmo.update_allowed && !rodc) { ldb_debug_set(ldb, LDB_DEBUG_ERROR, - "schema_data_modify: updates are not allowed: reject request\n"); + "schema_data_modify: updates are not allowed: reject modify request\n"); return LDB_ERR_UNWILLING_TO_PERFORM; }