From: Volker Lendecke <vl@samba.org>
Date: Tue, 25 Feb 2025 16:35:53 +0000 (+0100)
Subject: lib: Remove some dead code from ad_init()
X-Git-Tag: tevent-0.17.0~456
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a7fcb8e42563e414b1f7ee9befd805a72dcefb76;p=thirdparty%2Fsamba.git

lib: Remove some dead code from ad_init()

"rc" was never set to anything but 0.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/source3/lib/adouble.c b/source3/lib/adouble.c
index 6f5ffe35c8f..9a11498fda7 100644
--- a/source3/lib/adouble.c
+++ b/source3/lib/adouble.c
@@ -2547,7 +2547,6 @@ exit:
  **/
 struct adouble *ad_init(TALLOC_CTX *ctx, adouble_type_t type)
 {
-	int rc = 0;
 	const struct ad_entry_order  *eid;
 	struct adouble *ad = NULL;
 	time_t t = time(NULL);
@@ -2580,9 +2579,6 @@ struct adouble *ad_init(TALLOC_CTX *ctx, adouble_type_t type)
 	ad_setdate(ad, AD_DATE_ACCESS | AD_DATE_UNIX, t);
 	ad_setdate(ad, AD_DATE_BACKUP, htonl(AD_DATE_START));
 
-	if (rc != 0) {
-		TALLOC_FREE(ad);
-	}
 	return ad;
 }