From: Andrey Konovalov Date: Wed, 29 Mar 2017 14:11:22 +0000 (+0200) Subject: net/packet: fix overflow in check for tp_reserve X-Git-Tag: v3.10.107~22 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a8069aeebf93c1f3a397364a44cddaa90ff472f3;p=thirdparty%2Fkernel%2Fstable.git net/packet: fix overflow in check for tp_reserve commit bcc5364bdcfe131e6379363f089e7b4108d35b70 upstream. When calculating po->tp_hdrlen + po->tp_reserve the result can overflow. Fix by checking that tp_reserve <= INT_MAX on assign. Signed-off-by: Andrey Konovalov Acked-by: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Willy Tarreau --- diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index cea85d8de1d80..0bbb3470fa785 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -3187,6 +3187,8 @@ packet_setsockopt(struct socket *sock, int level, int optname, char __user *optv return -EBUSY; if (copy_from_user(&val, optval, sizeof(val))) return -EFAULT; + if (val > INT_MAX) + return -EINVAL; po->tp_reserve = val; return 0; }