From: Wouter Wijngaards Date: Fri, 21 Sep 2007 13:34:44 +0000 (+0000) Subject: Fixup alloc in wrong region. X-Git-Tag: release-0.5~13 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a81e19a6ebb01ece105b08c651d4b4862c6f9e13;p=thirdparty%2Funbound.git Fixup alloc in wrong region. git-svn-id: file:///svn/unbound/trunk@628 be551aaa-1e26-0410-a405-d3ace91eadb9 --- diff --git a/doc/Changelog b/doc/Changelog index 026681345..c2f62cfb1 100644 --- a/doc/Changelog +++ b/doc/Changelog @@ -1,3 +1,6 @@ +21 September 2007: Wouter + - fixup empty_DS_name allocated in wrong region. + 20 September 2007: Wouter - fixup and test for NSEC wildcard with empty nonterminals. - makedist.sh fixup for svn info. diff --git a/doc/TODO b/doc/TODO index 19e611578..09534df60 100644 --- a/doc/TODO +++ b/doc/TODO @@ -52,3 +52,4 @@ o grab ports nonconsequtive and change the set after a while (change within o workaround for nxdomain responses for ENT DS queries. Not look at rcode and look at valid empty nonterminal proof that is inside the packet. o make timeout backoffs randomized (a couple percent random) to spread traffic. +o inspect date on executable, then warn user in log if its more than 1 year. diff --git a/doc/plan b/doc/plan index e66c72097..57d533473 100644 --- a/doc/plan +++ b/doc/plan @@ -178,6 +178,8 @@ Styleguide: if phase 1, start servicing, phase is 0 again. Make robust against delays. readme: max about 1 second worth of incoming queries, 10k perhaps, or 1/number of seconds it takes start up of 10k. +* should the source include a copy of the ldns lib for ease of building by + new users. *** Local zones feature. * Build in local zone features. First the total stop for1912. diff --git a/validator/validator.c b/validator/validator.c index 6caf80e63..e9a69fd77 100644 --- a/validator/validator.c +++ b/validator/validator.c @@ -1789,7 +1789,14 @@ process_ds_response(struct module_qstate* qstate, struct val_qstate* vq, return; } if(dske == NULL) { - vq->empty_DS_name = qinfo->qname; + vq->empty_DS_name = region_alloc_init(qstate->region, + qinfo->qname, qinfo->qname_len); + if(!vq->empty_DS_name) { + log_err("malloc failure in empty_DS_name"); + vq->key_entry = NULL; /* make it error */ + vq->state = VAL_VALIDATE_STATE; + return; + } vq->empty_DS_len = qinfo->qname_len; /* ds response indicated that we aren't on a delegation point. * Keep the forState.state on FINDKEY. */