From: Kisub Choe Date: Fri, 20 Jun 2025 16:54:32 +0000 (+0900) Subject: staging: sm750fb: remove function pointer proc_setBLANK X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a87d8d7bcc664fc8302e2ba1cc213addaa87d689;p=thirdparty%2Flinux.git staging: sm750fb: remove function pointer proc_setBLANK Call a function based on sm750_dev->revid instead of using this indirection Signed-off-by: Kisub Choe Link: https://lore.kernel.org/r/aFWSSAcboBVi4ROh@zinc Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 62d8701d18dd0..b94bdede2993e 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -571,13 +571,19 @@ exit: static int lynxfb_ops_blank(int blank, struct fb_info *info) { + struct sm750_dev *sm750_dev; struct lynxfb_par *par; struct lynxfb_output *output; pr_debug("blank = %d.\n", blank); par = info->par; output = &par->output; - return output->proc_setBLANK(output, blank); + sm750_dev = par->dev; + + if (sm750_dev->revid == SM750LE_REVISION_ID) + return hw_sm750le_set_blank(output, blank); + else + return hw_sm750_set_blank(output, blank); } static int sm750fb_set_drv(struct lynxfb_par *par) @@ -605,8 +611,6 @@ static int sm750fb_set_drv(struct lynxfb_par *par) crtc->ypanstep = 1; crtc->ywrapstep = 0; - output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ? - hw_sm750le_set_blank : hw_sm750_set_blank; /* chip specific phase */ sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ? hw_sm750le_de_wait : hw_sm750_de_wait; diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 52ccf1b51630e..d7f40efe3a2ce 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -169,8 +169,6 @@ struct lynxfb_output { * output->channel ==> &crtc->channel */ void *priv; - - int (*proc_setBLANK)(struct lynxfb_output *output, int blank); }; struct lynxfb_par {