From: Willy Tarreau <w@1wt.eu>
Date: Wed, 24 Jun 2026 12:57:20 +0000 (+0200)
Subject: DEBUG: cli: relax tid check in "debug dev task" for recent sched changes
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a8aba33f09b4a9b7e4ebf4aea653114158019f8a;p=thirdparty%2Fhaproxy.git

DEBUG: cli: relax tid check in "debug dev task" for recent sched changes

Since commit 0988b9c773 ("MEDIUM: tasks: Remove the per-thread group
wait queue") in 3.5-dev, a task's tid may be as negative as -MAX_THREAD-1
and not just -1, so we must accept this when trying to check if a pointer
looks like a valid task.

No backport is needed.
---

diff --git a/src/debug.c b/src/debug.c
index cdb98584c..35369e1e9 100644
--- a/src/debug.c
+++ b/src/debug.c
@@ -1523,7 +1523,7 @@ static int debug_parse_cli_task(char **args, char *payload, struct appctx *appct
 	 * the TASK_COMMON part.
 	 */
 	if (!may_access(ptr) || !may_access(ptr + sizeof(struct tasklet) - 1) ||
-	    ((const struct tasklet *)ptr)->tid  < -1 ||
+	    ((const struct tasklet *)ptr)->tid  < -1 - MAX_THREADS||
 	    ((const struct tasklet *)ptr)->tid  >= (int)MAX_THREADS) {
 		ret = cli_err(appctx, "The designated memory area doesn't look like a valid task/tasklet\n");
 		goto leave;