From: Tim Düsterhus <tim@bastelstu.be>
Date: Sat, 11 Sep 2021 15:02:33 +0000 (+0200)
Subject: CLEANUP: ebmbtree: Replace always-taken elseif by else
X-Git-Tag: v2.5-dev7~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a8bfb4d13579b9f7d546261938b452fd9f875d0b;p=thirdparty%2Fhaproxy.git

CLEANUP: ebmbtree: Replace always-taken elseif by else

`diff` is guaranteed to be less than 0, because the `if` handles the `>= 0`
case.

Found using GitHub's CodeQL scan in HAProxy's codebase.
---

diff --git a/include/import/ebmbtree.h b/include/import/ebmbtree.h
index f99c16ba9a..1a45426247 100644
--- a/include/import/ebmbtree.h
+++ b/include/import/ebmbtree.h
@@ -358,7 +358,7 @@ __ebmb_insert(struct eb_root *root, struct ebmb_node *new, unsigned int len)
 		new->node.leaf_p = new_rght;
 		*up_ptr = new_left;
 	}
-	else if (diff < 0) {
+	else {
 		new->node.branches.b[EB_LEFT] = new_leaf;
 		new->node.branches.b[EB_RGHT] = troot;
 		new->node.leaf_p = new_left;