From: Daniel P. Berrangé <berrange@redhat.com>
Date: Tue, 6 Apr 2021 11:00:00 +0000 (+0100)
Subject: tests: add warning that qemucapsprobe prefers native host/guest arch
X-Git-Tag: v7.3.0-rc1~363
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a8c9b49747c0ece94da0c9a87a0e0575fb66f9a6;p=thirdparty%2Flibvirt.git

tests: add warning that qemucapsprobe prefers native host/guest arch

Generally we want the QEMU capabilities data in git to report KVM
related features, and thus we strongly prefer that the capabilities are
generated on a native host.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/tests/qemucapsprobe.c b/tests/qemucapsprobe.c
index 26ea9ff5ed..a89d9c8feb 100644
--- a/tests/qemucapsprobe.c
+++ b/tests/qemucapsprobe.c
@@ -46,6 +46,8 @@ main(int argc, char **argv)
 {
     virThread thread;
     virQEMUCapsPtr caps;
+    virArch host;
+    virArch guest;
     const char *mock = VIR_TEST_MOCK("qemucapsprobe");
 
     if (!virFileIsExecutable(mock)) {
@@ -80,6 +82,18 @@ main(int argc, char **argv)
                                                  -1, -1, NULL, 0, NULL)))
         return EXIT_FAILURE;
 
+    host = virArchFromHost();
+    guest = virQEMUCapsGetArch(caps);
+
+    if (host != guest) {
+        fprintf(stderr,
+                "WARNING: guest architecture '%s' does not match host '%s'.\n"
+                "WARNING: When generating capabilities for the libvirt test\n"
+                "WARNING: suite, it is strongly desired to generate capabilities\n"
+                "WARNING: on the native host to capture KVM related features.\n",
+                virArchToString(guest), virArchToString(host));
+    }
+
     virObjectUnref(caps);
 
     return EXIT_SUCCESS;