From: Ján Tomko <jtomko@redhat.com>
Date: Thu, 18 Feb 2021 13:16:36 +0000 (+0100)
Subject: qemu: saveimage: only steal domXML on success
X-Git-Tag: v7.1.0-rc1~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a8ed27e70a006083c528b2571bbbc0afa80fb5f4;p=thirdparty%2Flibvirt.git

qemu: saveimage: only steal domXML on success

The comment and the caller assume virQEMUSaveDataNew only steals
domXML on success, but it is copied even on failure.

Also remove the misleading g_steal_pointer call on a local variable.

Reported by coverity.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
---

diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index de2d63dd9a..5d542bf977 100644
--- a/src/qemu/qemu_saveimage.c
+++ b/src/qemu/qemu_saveimage.c
@@ -105,8 +105,6 @@ virQEMUSaveDataNew(char *domXML,
 
     data = g_new0(virQEMUSaveData, 1);
 
-    data->xml = g_steal_pointer(&domXML);
-
     if (cookieObj &&
         !(data->cookie = virSaveCookieFormat((virObjectPtr) cookieObj,
                                              virDomainXMLOptionGetSaveCookie(xmlopt))))
@@ -118,6 +116,7 @@ virQEMUSaveDataNew(char *domXML,
     header->was_running = running ? 1 : 0;
     header->compressed = compressed;
 
+    data->xml = domXML;
     return data;
 
  error: