From: Jorge Marques <jorge.marques@analog.com>
Date: Sun, 22 Jun 2025 10:11:07 +0000 (+0200)
Subject: i3c: master: Initialize ret in i3c_i2c_notifier_call()
X-Git-Tag: v6.1.149~271
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a8ed3757af53b440efc53d78d9e55c8cd87e5499;p=thirdparty%2Fkernel%2Fstable.git

i3c: master: Initialize ret in i3c_i2c_notifier_call()

[ Upstream commit 290ce8b2d0745e45a3155268184523a8c75996f1 ]

Set ret to -EINVAL if i3c_i2c_notifier_call() receives an invalid
action, resolving uninitialized warning.

Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250622-i3c-master-ret-uninitialized-v1-1-aabb5625c932@analog.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 513c79e26d9a3..019fd9bd928d0 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2413,6 +2413,8 @@ static int i3c_i2c_notifier_call(struct notifier_block *nb, unsigned long action
 	case BUS_NOTIFY_DEL_DEVICE:
 		ret = i3c_master_i2c_detach(adap, client);
 		break;
+	default:
+		ret = -EINVAL;
 	}
 	i3c_bus_maintenance_unlock(&master->bus);