From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 11 Nov 2021 21:57:26 +0000 (-0500)
Subject: functions return fr_pair_t*, not void*
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a8f90ec561ab8f0173afbfcbe02d57b2ec606495;p=thirdparty%2Ffreeradius-server.git

functions return fr_pair_t*, not void*
---

diff --git a/src/lib/util/pair.c b/src/lib/util/pair.c
index ad9615c356..5faffe50b1 100644
--- a/src/lib/util/pair.c
+++ b/src/lib/util/pair.c
@@ -925,7 +925,7 @@ fr_pair_t *_fr_pair_dcursor_by_ancestor_init(fr_dcursor_t *cursor,
  *	- pointer to the first item in the list.
  * @hidecallergraph
  */
-void *fr_pair_list_head(fr_pair_list_t const *list)
+fr_pair_t *fr_pair_list_head(fr_pair_list_t const *list)
 {
 	return fr_dlist_head(&list->order);
 }
@@ -939,7 +939,7 @@ void *fr_pair_list_head(fr_pair_list_t const *list)
  *	- pointer to the next item
  * @hidecallergraph
  */
-void *fr_pair_list_next(fr_pair_list_t const *list, fr_pair_t const *item)
+fr_pair_t *fr_pair_list_next(fr_pair_list_t const *list, fr_pair_t const *item)
 {
 	return fr_dlist_next(&list->order, item);
 }
@@ -952,7 +952,7 @@ void *fr_pair_list_next(fr_pair_list_t const *list, fr_pair_t const *item)
  *	- NULL if the head of the list has been reached
  *	- pointer to the previous item
  */
-void *fr_pair_list_prev(fr_pair_list_t const *list, fr_pair_t const *item)
+fr_pair_t *fr_pair_list_prev(fr_pair_list_t const *list, fr_pair_t const *item)
 {
 	return fr_dlist_prev(&list->order, item);
 }
@@ -965,7 +965,7 @@ void *fr_pair_list_prev(fr_pair_list_t const *list, fr_pair_t const *item)
  *	- NULL if the list is empty
  *	- pointer to the last item in the list.
  */
-void *fr_pair_list_tail(fr_pair_list_t const *list)
+fr_pair_t *fr_pair_list_tail(fr_pair_list_t const *list)
 {
 	return fr_dlist_tail(&list->order);
 }
diff --git a/src/lib/util/pair.h b/src/lib/util/pair.h
index f3a55c81c9..ac665af516 100644
--- a/src/lib/util/pair.h
+++ b/src/lib/util/pair.h
@@ -438,14 +438,14 @@ void		fr_pair_list_append(fr_pair_list_t *dst, fr_pair_list_t *src) CC_HINT(nonn
 void		fr_pair_list_prepend(fr_pair_list_t *dst, fr_pair_list_t *src) CC_HINT(nonnull);
 
 /** @hidecallergraph */
-void		*fr_pair_list_head(fr_pair_list_t const *list) CC_HINT(nonnull);
+fr_pair_t	*fr_pair_list_head(fr_pair_list_t const *list) CC_HINT(nonnull);
 
 /** @hidecallergraph */
-void		*fr_pair_list_next(fr_pair_list_t const *list, fr_pair_t const *item) CC_HINT(nonnull(1));
+fr_pair_t      	*fr_pair_list_next(fr_pair_list_t const *list, fr_pair_t const *item) CC_HINT(nonnull(1));
 
-void		*fr_pair_list_prev(fr_pair_list_t const *list, fr_pair_t const *item) CC_HINT(nonnull(1));
+fr_pair_t      	*fr_pair_list_prev(fr_pair_list_t const *list, fr_pair_t const *item) CC_HINT(nonnull(1));
 
-void		*fr_pair_list_tail(fr_pair_list_t const *list) CC_HINT(nonnull);
+fr_pair_t      	*fr_pair_list_tail(fr_pair_list_t const *list) CC_HINT(nonnull);
 
 /** @name Pair to pair copying
  *