From: Andreas Schneider <asn@samba.org>
Date: Wed, 23 May 2018 15:35:15 +0000 (+0200)
Subject: s3:utils: Remove double error check
X-Git-Tag: ldb-1.4.0~65
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a9084dce29d9e0e76a3485edfca26add361988ba;p=thirdparty%2Fsamba.git

s3:utils: Remove double error check

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Thu May 24 18:07:03 CEST 2018 on sn-devel-144
---

diff --git a/source3/utils/net_dns.c b/source3/utils/net_dns.c
index 9ee856c0059..b94bef987a1 100644
--- a/source3/utils/net_dns.c
+++ b/source3/utils/net_dns.c
@@ -96,10 +96,9 @@ DNS_ERROR DoDNSUpdate(char *pszServerName,
 		if (!ERR_DNS_IS_OK(err)) goto error;
 
 		err = dns_update_transaction(mem_ctx, conn, req, &resp);
-		if (!ERR_DNS_IS_OK(err)) goto error;
-
 		if (!ERR_DNS_IS_OK(err)) {
 			DEBUG(3,("DoDNSUpdate: unsigned update failed\n"));
+			goto error;
 		}
 
 		if ((dns_response_code(resp->flags) == DNS_NO_ERROR) &&