From: lpsolit%gmail.com <>
Date: Thu, 3 Sep 2009 19:08:52 +0000 (+0000)
Subject: Bug 509794: Crash if setting a flag with Unicode characters in the name - Patch by... 
X-Git-Tag: bugzilla-3.4.2~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a91a107196ff788532364d08e00896e624eef1b9;p=thirdparty%2Fbugzilla.git

Bug 509794: Crash if setting a flag with Unicode characters in the name - Patch by Frédéric Buclin <LpSolit@gmail.com> r=bbaetz a=LpSolit
---

diff --git a/template/en/default/request/email.txt.tmpl b/template/en/default/request/email.txt.tmpl
index 81948c42c5..9ba7aa2431 100644
--- a/template/en/default/request/email.txt.tmpl
+++ b/template/en/default/request/email.txt.tmpl
@@ -74,7 +74,8 @@ Attachment [% attidsummary %]
 [%- FILTER bullet = wrap(80) %]
 
 [% USE Bugzilla %]
-[% IF Bugzilla.cgi.param("comment") && Bugzilla.cgi.param("comment").length > 0 %]
+[%-# .defined is necessary to avoid a taint issue in Perl < 5.10.1, see bug 509794. %]
+[% IF Bugzilla.cgi.param("comment").defined && Bugzilla.cgi.param("comment").length > 0 %]
 ------- Additional Comments from [% user.identity %]
 [%+ Bugzilla.cgi.param("comment") %]
 [% END %]